This repository was archived by the owner on Feb 1, 2023. It is now read-only.
Merged
Conversation
9 tasks
iand
approved these changes
Apr 28, 2022
|
Are test failures related to this change? |
Contributor
Author
|
Yes, I need to fix them, meant to open this as a draft until I work those out |
e10d5e3 to
b434e4a
Compare
Contributor
Author
|
OK it's good to go now, the remaining test failures are known flaky tests documented in ipfs/boxo#86 |
|
LGTM |
9938db9 to
d8491b6
Compare
This adds tracing spans to the costly Bitswap entry points. It doesn't instrument the bitswap internals, which will take some time. In go-ipfs, this will at least let us know the contribution of Bitswap to the overall request handling time. This also plumbs contexts through internally so that they reach the content routing APIs, so that traces are propagated through and we can start instrumenting e.g. the DHT.
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds tracing spans to the costly Bitswap entry points. It doesn't
instrument the bitswap internals, which will take some time. In
go-ipfs, this will at least let us know the contribution of Bitswap to
the overall request handling time.
This also plumbs contexts through internally so that they reach the
content routing APIs, so that traces are propagated through and we can
start instrumenting e.g. the DHT.