Skip to content

fix(add-version): only run build on CI#736

Merged
lidel merged 1 commit intomasterfrom
only-run-build-on-CI
Jul 19, 2022
Merged

fix(add-version): only run build on CI#736
lidel merged 1 commit intomasterfrom
only-run-build-on-CI

Conversation

@Jorropo
Copy link
Contributor

@Jorropo Jorropo commented Jul 7, 2022

No description provided.

@Jorropo Jorropo requested a review from lidel July 7, 2022 22:55
@Jorropo Jorropo self-assigned this Jul 7, 2022
Copy link
Member

@lidel lidel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(will review after #717 is merged)

@Jorropo Jorropo temporarily deployed to Deploy July 7, 2022 23:30 Inactive
@Jorropo
Copy link
Contributor Author

Jorropo commented Jul 7, 2022

Github's UI isn't actualising and doesn't understand that we merged some commits of this in master already, the real diff is:

diff --git a/dist.sh b/dist.sh
index 05df1af..3e15a8f 100755
--- a/dist.sh
+++ b/dist.sh
@@ -105,7 +105,9 @@ case $1 in
 
                # cd "dists/$dist" && make update_sources
                # build-go will update sources as needed
-               cd "dists/$dist" && make
+               if [ "$CI" == "true" ]; then
+                       cd "dists/$dist" && make
+               fi
                ;;
        *)
                echo "unrecognized command $1"

(merge will be fine as long as we merge, idk about rebase or squash)

@github-actions

This comment was marked as off-topic.

@lidel lidel changed the title Only run build on ci fix(add-version): only run build on CI Jul 19, 2022
@lidel lidel temporarily deployed to Deploy July 19, 2022 19:23 Inactive
@lidel lidel force-pushed the only-run-build-on-CI branch from 0f515b9 to 14d1fd0 Compare July 19, 2022 19:25
@lidel lidel enabled auto-merge July 19, 2022 19:26
@github-actions
Copy link

This change produced no new differences in built artifacts.

@lidel lidel temporarily deployed to Deploy July 19, 2022 19:32 Inactive
@github-actions
Copy link

This change produced no new differences in built artifacts.

@lidel lidel merged commit a9848af into master Jul 19, 2022
@lidel lidel deleted the only-run-build-on-CI branch July 19, 2022 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants