Bitswap: fix double-worker in connectEventManager. Logging improvements. #986
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Probably the root cause behind the latest connect/disconnect issues.
Codecov Report❌ Patch coverage is @@ Coverage Diff @@
## main #986 +/- ##
==========================================
- Coverage 61.53% 61.52% -0.01%
==========================================
Files 254 254
Lines 31542 31567 +25
==========================================
+ Hits 19408 19422 +14
- Misses 10548 10558 +10
- Partials 1586 1587 +1
... and 3 files with indirect coverage changes 🚀 New features to boost your workflow:
|
gammazero
approved these changes
Jul 29, 2025
Contributor
gammazero
left a comment
There was a problem hiding this comment.
A couple minor wording suggestions.
Co-authored-by: Andrew Gillis <11790789+gammazero@users.noreply.github.com>
Co-authored-by: Andrew Gillis <11790789+gammazero@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should potentially fix the last source of racing connect-disconnects.