bitswap/httpnet: fix peers silently stopping from doing http requests #980
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #979 (hopefully). If connectivity status has been switched from Connected without doing an httpnet DisconnectFrom(), it may be that we keep pinging the peers, and think we are connected to them, but never restore the connectivity status when skipping the connectivity checks (because we are connected). This results in silent, successful "Connect()" requests that do nothing.
c090691 to
bc0ab3a
Compare
Codecov ReportAttention: Patch coverage is
@@ Coverage Diff @@
## main #980 +/- ##
==========================================
+ Coverage 61.52% 61.54% +0.02%
==========================================
Files 254 254
Lines 31487 31494 +7
==========================================
+ Hits 19371 19382 +11
+ Misses 10529 10524 -5
- Partials 1587 1588 +1
... and 10 files with indirect coverage changes 🚀 New features to boost your workflow:
|
gammazero
approved these changes
Jul 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #979 (hopefully). If connectivity status has been switched from Connected without doing an httpnet DisconnectFrom(), it may be that we keep pinging the peers, and think we are connected to them, but never restore the connectivity status when skipping the connectivity checks (because we are connected). This results in silent, successful "Connect()" requests that do nothing.