feat(ipld/unixfs): DagModifier: allow specifying MaxLinks per file #898
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hsanjuan
commented
Mar 26, 2025
Contributor
Author
hsanjuan
left a comment
There was a problem hiding this comment.
I am not sure that we are going to make immediate use of this, but probably good to have.
Most immediate usecase would be to support MaxLinks in MFS if we wanted.
Contributor
Author
|
On second thoughts, we might need this since adding uses MFS.. |
gammazero
approved these changes
Mar 28, 2025
Contributor
gammazero
left a comment
There was a problem hiding this comment.
Is this value ever written anywhere? Is not, maybe better to just use a const so everyone knows it is a fixed read-only value. Otherwise LGTM.
lidel
approved these changes
Mar 28, 2025
Member
|
lgtm, we will expose it as configuration option, part of ipfs/kubo#10751 |
lidel
reviewed
Apr 7, 2025
|
|
||
| Prefix cid.Prefix | ||
| RawLeaves bool | ||
| MaxLinks int |
Member
There was a problem hiding this comment.
@hsanjuan is this enough, given we've added separate setting for HAMT? (#897 (review))
Contributor
Author
There was a problem hiding this comment.
It is probably enough since this seems to deal only with files...
lidel
approved these changes
Apr 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc ipfs/kubo#10751