feat: Better self-service commands for DHT providing#815
feat: Better self-service commands for DHT providing#815guillaumemichel merged 7 commits intoipfs:mainfrom gsergey418:feat/10265-routing-cmd
Conversation
|
Thank you for submitting this PR!
Getting other community members to do a review would be great help too on complex PRs (you can ask in the chats/forums). If you are unsure about something, just leave us a comment.
We currently aim to provide initial feedback/triaging within two business days. Please keep an eye on any labelling actions, as these will indicate priorities and status of your contribution. |
Codecov ReportAttention: Patch coverage is
@@ Coverage Diff @@
## main #815 +/- ##
==========================================
- Coverage 60.46% 60.45% -0.02%
==========================================
Files 244 244
Lines 31097 31100 +3
==========================================
- Hits 18803 18800 -3
- Misses 10616 10622 +6
Partials 1678 1678
|
guillaumemichel
left a comment
There was a problem hiding this comment.
Looks good, but waiting on ipfs/kubo#10677 CI to be green before merging.
|
For the CI to pass, it needs this PR as a dependency. It won't build without the ReproviderStats structure containing the right values. You would have to merge this one first. |
|
I could update the go.mod file of the kubo PR to point to the right branch on my fork, but you'd have to undo it before merging. |
|
Just did that, you can approve the workflows. |
Yes, I did it in ipfs/kubo@439f2d4 |
|
@gsergey418alt I updated the logic, let me know if it works for you |
|
@guillaumemichel Yeah, it's probably a better idea to compute NextRun when displaying the stats. |
Add LastRun and NextRun stats. Fixes Kubo issue #10265.