fix/gateway: escape directory redirect url#779
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
@@ Coverage Diff @@
## main #779 +/- ##
==========================================
- Coverage 60.51% 60.49% -0.02%
==========================================
Files 245 245
Lines 31126 31126
==========================================
- Hits 18835 18831 -4
- Misses 10622 10623 +1
- Partials 1669 1672 +3
|
Directories with a "%" in their name do not work correctly when when redirected to a URL with a trailing slash. When the original URl contains special characters, such as "%", the correcponding redirect URL must escape these characters. Fixes issue ipfs/kubo#10536
f71abb0 to
16d89a5
Compare
hsanjuan
approved these changes
Jan 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a directory gets redirected to a URL with a treailing slash, special chars in the directory name must be escaped in the redirect URL.
Depends on ipfs/gateway-conformance#225
Required by: ipfs/kubo#10649
Fixes issue ipfs/kubo#10536
TODO:
.github/workflows/gateway-sharness.ymlreffrom.github/workflows/gateway-sharness.ymlafter merge of this PR and merge of kubo PR