Codecov Report

Merging #334 (9252a2b) into main (b388690) will increase coverage by 0.03%.
The diff coverage is 71.54%.

@@            Coverage Diff             @@
##             main     #334      +/-   ##
==========================================
+ Coverage   65.69%   65.72%   +0.03%     
==========================================
  Files         209      207       -2     
  Lines       25196    25131      -65     
==========================================
- Hits        16552    16518      -34     
+ Misses       7177     7151      -26     
+ Partials     1467     1462       -5     

... and 12 files with indirect coverage changes

@ipfs/kubo-maintainers I think this is something important to get out of the door for many reasons (see #198). I just rebased this work I did in June on top of the recent changes. I can only imagine this having large repercussions thorough our other packages, especially Kubo. Therefore, before continuing, I would like to ask for some feedback regarding the Path interface.

One of the biggest changes is the removal of the IsValid() bool function from the path type. The idea is that if a path exists, then it must be valid. There's no point on passing around a path that will be invalid and always calling for IsValid(). Now the verification is done at creation time. This is what scares me the most when bubbling this to Kubo, as processes that would otherwise fail later in the process will now fail earlier. Or maybe not the case.

@aschmahmann @lidel I want to ping you for a re-review. I've already addressed the feedback, tests are passing here and in Kubo. This PR is almost turning 4 months old and I really don't want that to happen.

To avoid making waves this difficult month, I think we should minimize risk and ship this in Kubo 0.24, and we should wait with merge until 0.23 ships.

It already has: https://github.com/ipfs/kubo/releases/tag/v0.23.0!

I am going to go ahead and merge this. I think it has marinated for enough time and I've already addressed the feedbacks we had. Tests are passing here and in Kubo, and Kubo 0.23 has been released. So merging this at the beginning of the new release cycle (0.24) will allow us to test it until the final release of 0.24.