fix(gateway): deduplicate peer IDs in retrieval diagnostics#1058
Merged
Conversation
peer IDs could appear multiple times in timeout errors due to repeated connection failures. add deduplication check.
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## main #1058 +/- ##
==========================================
+ Coverage 60.73% 61.09% +0.36%
==========================================
Files 268 268
Lines 33593 26130 -7463
==========================================
- Hits 20402 15964 -4438
+ Misses 11516 8496 -3020
+ Partials 1675 1670 -5
... and 249 files with indirect coverage changes 🚀 New features to boost your workflow:
|
aschmahmann
approved these changes
Oct 23, 2025
Contributor
aschmahmann
left a comment
There was a problem hiding this comment.
LGTM (albeit this code path is new and I'm not very familiar with it)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
peer IDs could appear multiple times in timeout errors due to repeated connection failures. add deduplication check.
cc @aschmahmann (thx for noticing!)