bitswap/httpnet: improve "Connect"/testCid check#1057
Merged
Conversation
Codecov Report❌ Patch coverage is @@ Coverage Diff @@
## main #1057 +/- ##
==========================================
- Coverage 61.06% 61.05% -0.01%
==========================================
Files 268 268
Lines 26130 26154 +24
==========================================
+ Hits 15956 15969 +13
- Misses 8501 8509 +8
- Partials 1673 1676 +3
... and 4 files with indirect coverage changes 🚀 New features to boost your workflow:
|
gammazero
requested changes
Oct 24, 2025
lidel
reviewed
Oct 28, 2025
aschmahmann
reviewed
Oct 28, 2025
Now that we have certain safeguards to disconnect from small providers, we can be more open to connect to places that fail the "testCid request". Particularly places that return 500 with known error messages that prove that they understand ipld and that they are a gateway.
explains why we accept 5xx with known IPLD error messages and references https://specs.ipfs.tech/architecture/principles/#robustness
d0b2074 to
51a4e0e
Compare
gammazero
approved these changes
Oct 29, 2025
lidel
approved these changes
Oct 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now that we have certain safeguards to disconnect from small providers, we can be more open to connect to places that fail the "testCid request". Particularly places that return 500 with known error messages that prove that they understand ipld and that they are a gateway.