generated from ipfs/ipfs-repository-template
-
Notifications
You must be signed in to change notification settings - Fork 153
Closed
Labels
need/analysisNeeds further analysis before proceedingNeeds further analysis before proceedingneed/maintainers-inputNeeds input from the current maintainer(s)Needs input from the current maintainer(s)
Description
We've been running long-running Bitswap sessions and encountered a series of memory leaks that we've successfully identified and fixed in our fork. I plan to start upstreaming them eventually, but I am currently botted with millions of things. Anyway, I want to make you aware of their existence already in case you have the capacity to look into those.
The full branch is located here. Some of them were merged, some of them aren't. The most notable are:
- fix leak ensuring SessionInterestManager is cleaned up
- fix leak in block presence manager along with
- cleanup toFetch cidqueue
- cleanup peerresponsetracker
- rebroadcast only when there are live CIDs - not a leak, resolves issue with timer continue ticking even when there are not CIDs to rebroadcast further
All of those fixes have been tested on hundreds of nodes in production, and things have been running smoothly and steadily for 3 weeks. I am happy to answer if you start working on this sooner than when I get to opening PRs myself.
cc @hsanjuan, @gammazero, @lidel
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
need/analysisNeeds further analysis before proceedingNeeds further analysis before proceedingneed/maintainers-inputNeeds input from the current maintainer(s)Needs input from the current maintainer(s)