Skip to content

replaceCargoLockHook: run as prePatchHook not postUnpack#434

Merged
ipetkov merged 1 commit intomasterfrom
override
Oct 17, 2023
Merged

replaceCargoLockHook: run as prePatchHook not postUnpack#434
ipetkov merged 1 commit intomasterfrom
override

Conversation

@ipetkov
Copy link
Copy Markdown
Owner

@ipetkov ipetkov commented Oct 17, 2023

Motivation

Copying the overridden Cargo.lock cannot be done as a postUnpack hook because the builder does not cd into the unpacked source until after those hooks are done (thus we effectively end up linking the Cargo.lock to .. when the build runs).

The fix is to change the hook to run later as a prePatch hook

Fixes #422

Checklist

  • added tests to verify new behavior
  • added an example template or updated an existing one
  • updated docs/API.md (or general documentation) with changes
  • updated CHANGELOG.md

@ipetkov ipetkov enabled auto-merge (squash) October 17, 2023 03:07
@ipetkov ipetkov merged commit eb5034b into master Oct 17, 2023
@ipetkov ipetkov deleted the override branch October 17, 2023 03:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix: build crane-utils using a different toolchain

1 participant