Fix(IPRange): Allow contains() to accept single IP addresses#104
Merged
Fix(IPRange): Allow contains() to accept single IP addresses#104
Conversation
The contains() method in IPv4CidrRange and IPv6CidrRange now correctly handles being passed an IPv4 or IPv6 instance directly. Previously, it only worked correctly if passed another range instance, causing a TypeError when a single IP address was provided. This change modifies AbstractIPRange.contains() to check the type of the argument. If it's an AbstractIPNum (i.e., a single IP address), it compares the IP's value against the range's start and end values. Otherwise, it uses the existing logic for comparing two ranges. I added unit tests for both IPv4 and IPv6 to verify that an IP address can be correctly checked if it's contained within a CIDR range, including edge cases. Also, I updated the 'ipnum-build' script in package.json to include NODE_OPTIONS=--openssl-legacy-provider to resolve a local build issue with Webpack related to OpenSSL provider errors.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #97
The contains() method in IPv4CidrRange and IPv6CidrRange now correctly handles being passed an IPv4 or IPv6 instance directly. Previously, it only worked correctly if passed another range instance, causing a TypeError when a single IP address was provided.
This change modifies AbstractIPRange.contains() to check the type of the argument. If it's an AbstractIPNum (i.e., a single IP address), it compares the IP's value against the range's start and end values. Otherwise, it uses the existing logic for comparing two ranges.