Fix: Validate CIDR range in isValidIPv4CidrNotation#102
Merged
Conversation
This commit removes an explanatory comment that was added during the previous fix for CIDR range validation. The comment, while technically correct, was deemed out of scope for the specific bug fix and could cause future confusion. The removal of this comment does not affect the functionality or the logic of the `isValidIPv4CidrNotation` function. All tests continue to pass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #100
The isValidIPv4CidrNotation function was vulnerable to a crash
if the range part of the CIDR string (e.g., '192.168.1.0/range')
contained non-numeric characters like a period. This was because
the function attempted to convert this part directly to a Number
and BigInt without sufficient validation.
This commit introduces a regular expression check ( /^\d+$/ )
to ensure that the range string consists only of digits before
any conversion is attempted. This prevents the SyntaxError when
BigInt conversion fails due to invalid characters.