cc, python: Clean up BPF module and tables#808
Merged
drzaeus77 merged 1 commit intoiovisor:masterfrom Nov 9, 2016
Merged
Conversation
Member
|
Thanks for the quick turnaround, this indeed fixes the problem I saw while trying out #774 |
When the `BPFModule` object is destroyed, shared tables were closed, but non-shared tables were not. Add `close` call to close non-shared tables in `~BPFModule`. Make sure the `BPF.cleanup` function in the Python module calls `bpf_module_destroy` to clean up the module. Otherwise, we have hanging table fds that aren't destroyed. Fixes iovisor#806. This would have been an issue for any tool that repeatedly runs a BPF program with new maps. It's just that most tools we have haven't exhibited this behavior.
Member
|
@goldshtn Do we also need to close the loaded program FDs? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the
BPFModuleobject is destroyed, shared tableswere closed, but non-shared tables were not. Add
closecall to close non-shared tables in
~BPFModule.Make sure the
BPF.cleanupfunction in the Python modulecalls
bpf_module_destroyto clean up the module. Otherwise,we have hanging table fds that aren't destroyed.
Fixes #806. This would have been an issue for any tool
that repeatedly runs a BPF program with new maps. It's just
that most tools we have haven't exhibited this behavior.