This repository was archived by the owner on May 20, 2025. It is now read-only.
Refactor MessageFactory, introduce ReferenceProvider and OrphanageManager#2240
Merged
jonastheis merged 48 commits intodevelopfrom Jun 16, 2022
Merged
Refactor MessageFactory, introduce ReferenceProvider and OrphanageManager#2240jonastheis merged 48 commits intodevelopfrom
jonastheis merged 48 commits intodevelopfrom
Conversation
…refactor-message-factory
…o chore/refactor-message-factory
…otaledger/goshimmer into chore/refactor-message-factory
… that are excluded
…r/goshimmer into chore/refactor-message-factory
…otaledger/goshimmer into chore/refactor-message-factory
…m forking markers (always propagate parent branches forward)
…kly and also via strong parent. Fixes integration test as well.
…otaledger/goshimmer into chore/refactor-message-factory
hmoog
commented
Jun 15, 2022
Contributor
Author
hmoog
left a comment
There was a problem hiding this comment.
LGTM - just this one question
|
|
||
| // TangleTimeWindow defines the time window in which the node considers itself as synced according to TangleTime. | ||
| TangleTimeWindow time.Duration `default:"2m" usage:"the time window in which the node considers itself as synced according to TangleTime"` | ||
| TangleTimeWindow time.Duration `default:"20m" usage:"the time window in which the node considers itself as synced according to TangleTime"` |
Contributor
Author
There was a problem hiding this comment.
Should we leave this at 20m?
Contributor
There was a problem hiding this comment.
It will change with the new TSC and time concepts release anyway. So imo it doesn't really matter.
jonastheis
approved these changes
Jun 15, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of change
This PR refactors the MessageFactory to be easier to maintain and solve the deep spamming reference error.
Type of change
Change checklist