Skip to content

Use more stable servers #298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ocefpaf merged 4 commits into from
Mar 31, 2023
Merged

Use more stable servers #298

ocefpaf merged 4 commits into from
Mar 31, 2023

Conversation

@ocefpaf
Copy link
Member

@ocefpaf ocefpaf commented Mar 31, 2023

I simplified the quick intro a lot to fix a more stable server. Fingers crossed!

@ocefpaf
Copy link
Member Author

ocefpaf commented Mar 31, 2023

It looks like the change in the caching documented in #297 (comment) did break something.

"""
Traceback (most recent call last):
  File "/home/runner/micromamba-root/envs/TEST/lib/python3.11/site-packages/joblib/externals/loky/backend/queues.py", line 125, in _feed
    obj_ = dumps(obj, reducers=reducers)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/runner/micromamba-root/envs/TEST/lib/python3.11/site-packages/joblib/externals/loky/backend/reduction.py", line 211, in dumps
    dump(obj, buf, reducers=reducers, protocol=protocol)
  File "/home/runner/micromamba-root/envs/TEST/lib/python3.11/site-packages/joblib/externals/loky/backend/reduction.py", line 204, in dump
    _LokyPickler(file, reducers=reducers, protocol=protocol).dump(obj)
  File "/home/runner/micromamba-root/envs/TEST/lib/python3.11/site-packages/joblib/externals/cloudpickle/cloudpickle_fast.py", line 632, in dump
    return Pickler.dump(self, obj)
           ^^^^^^^^^^^^^^^^^^^^^^^
_pickle.PicklingError: Can't pickle <functools._lru_cache_wrapper object at 0x7fd6153a0bf0>: it's not the same object as erddapy.erddapy.ERDDAP._get_variables_uncached
"""

However, the question is if we should be accessing a server like that or not. It has been discourage by data providers, so maybe we should remove that kind of parallel access from our docs altogether.

@ocefpaf
Copy link
Member Author

ocefpaf commented Mar 31, 2023

However, the question is if we should be accessing a server like that or not. It has been discourage by data providers, so maybe we should remove that kind of parallel access from our docs altogether.

OK. A compromise! Let's download less data, just the first 5 gliders, and use this opportunity to demonstrate the core functionality and how they expose erddapy's base functions.

@ocefpaf ocefpaf merged commit 9779b3f into ioos:main Mar 31, 2023
@ocefpaf ocefpaf deleted the docs branch March 31, 2023 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@ocefpaf