Skip to content

Use an all pyproject.toml setup #297

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ocefpaf merged 13 commits into from
Mar 31, 2023
Merged

Use an all pyproject.toml setup #297

ocefpaf merged 13 commits into from
Mar 31, 2023

Conversation

@ocefpaf
Copy link
Member

@ocefpaf ocefpaf commented Mar 30, 2023

I also moved the linting to ruff.

abkfenris
abkfenris reviewed Mar 30, 2023
View reviewed changes
MANIFEST.in
Copy link
Contributor

@abkfenris abkfenris Mar 30, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the manifest still necessary with pyproject.toml?

Copy link
Member Author

@ocefpaf ocefpaf Mar 30, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sadly we do. We have more control over the sdist with the MANIFEST. We can remove it and the sdist will be fine but we would be packaging some junk and making it a bit big. B/c PyPI has some size limitations I like to keep them small.

@ocefpaf
Copy link
Member Author

ocefpaf commented Mar 31, 2023

I'll address the docs failures in another PR, this one is already too big for its own sake.. This should be ready to go but I'd like to highlight this commits here in case it causes us problem in the future: ccfa937

Hopefully that addresses the memory leak caused by creating too many instances of the class without hurting the cache.

@ocefpaf
Copy link
Member Author

ocefpaf commented Mar 31, 2023

@abkfenris thanks for the dynamic requirement file tip. Looks much cleaner now!

@ocefpaf ocefpaf merged commit f7bb350 into ioos:main Mar 31, 2023
@ocefpaf ocefpaf deleted the pyproject.toml branch March 31, 2023 13:24
@ocefpaf ocefpaf mentioned this pull request Mar 31, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@abkfenris abkfenris abkfenris left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ocefpaf @abkfenris