Another attempt at fixing tests #272
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ocefpaf
reviewed
Oct 14, 2022
tests/test_to_objects.py
Outdated
| def dataset_tabledap(sensors): | ||
| """Load tabledap for testing.""" | ||
| sensors.dataset_id = "osmc_23091" | ||
| sensors.dataset_id = "org_cormp_cap2" |
Member
There was a problem hiding this comment.
Ah! Missed that and we should've probably had this in another PR to merge before trying to fix the macOS problem.
ocefpaf
reviewed
Oct 14, 2022
tests/test_to_objects.py
Outdated
| """Instantiate ERDDAP class for testing.""" | ||
| yield ERDDAP( | ||
| server="https://erddap.sensors.ioos.us/erddap/", | ||
| server="https://standards.sensors.ioos.us/erddap/", |
Member
There was a problem hiding this comment.
Same as https://github.com/ioos/erddapy/pull/272/files#r996095309, I ended up clobbering these changes b/c I wanted to separate the issues.
Member
|
Things are passing now \o/ Sorry for clobbering some of your changes but my old brain needed some separation of contexts here to understand all the failures. And thanks for tackling yet another maintenance PR! Those can be tedious but are as important as new code. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
to_xarraymethod error on OS X #261)