Skip to content

Conversation

@vinisalazar
Copy link
Contributor

This PR contains the same changes as #259 plus the last 3 commits, so it'd be easier to review it after merging that one.

Thanks,
Vini

Summary of changes

  • Refactor URL and griddap handling functions out of the erddapy.py module into their own modules in erddapy.core
  • Rename modules in erddapy.core
  • Refactor imports

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@vinisalazar vinisalazar mentioned this pull request Aug 11, 2022
  - Rename erddapy.core.url_handling to erddapy.core.url
  - Refactor imports
  - Rename erddapy.core.netcdf_handling to erddapy.core.netcdf
  - Refactor imports
  - Move URL handling functions to erddapy.core.url
  - Move GRIDDAP handling functions to erddapy.core.griddap
  - Refactor imports
@ocefpaf ocefpaf merged commit 0a340dc into ioos:main Aug 17, 2022
@vinisalazar vinisalazar deleted the refactor-erddapy branch August 31, 2022 17:08
@ocefpaf ocefpaf added the GSoC22 label Nov 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants