Refactor tests to use gold standard servers #260
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Refactor test URLs
- Change search string
- Record new cassette
- Refactor test URLs
- Change dataset_id, constraints, and variables
- "Turn off" griddap search for now
- Record new cassettes
- Refactor test URLs - Record new cassettes
- Refactor test URLs - Create fixture 'servers' - Record new cassettes
This was referenced Jul 27, 2022
- Modify dataset_id so correct error status will be raised (400, not 404) - Rewrite cassette
ocefpaf
approved these changes
Jul 28, 2022
Member
|
@vinisalazar the vrc cassetes are quite noisy in the PRs. if we can, when updating them, let's try to commit squash all the previous commits and add them after so we have only 2 commits: code changes and cassette updates. |
Contributor
Author
|
Sure, that makes sense, thanks for the feedback. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
this PR is in relation to #258.
I refactored tests to use the servers listed on the issue. I kept some tests as they are (in
test_to_objects.py) and modifiedtest_search_url_change_protocolintest_url_builder.pywhile there aren't any griddap datasets.While working on
test_to_objects.py, I ran into a problem with theto_xarraymethod. I wasn't able to read the NC dataset from memory, and detailed it in #261.Thanks,
Vini
Summary of changes
dataset_id,constraints, andvariables