Document search using 'allDatasets' method #251
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add cell to '00-quick_intro.ipynb' documenting this type of search
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
- Fix notebooks/00-quick_intro.ipynb to pass pre-commit check
Contributor
Author
|
I believe I'm running into the same problem as described here, pre-commit passes locally but fails on the CI. |
Member
We should disable that pre-commit check. It is causing more harm than good at this porint. Do you mind sending another PR to do that? |
This hook will be disabled while the CI problems persist. See deathbeds/prenotebook#6 for discussion.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, this is in relation to #14.
Summary of changes
The notebook built as expected using the command in the
deploy-docs.yamlfile.Please feel free to request any changes.
Thank you,
Vini