Moving from requests to httpx #245
Conversation
|
1834b53 Not possible. All servers are bad. |
Some a less bad then others :-) At least I can run some live tests with these ones without being kicked out for making two requests within a short period of time. |
|
@abkfenris tnis PR is good to go but I'd love your input before merging. The change seems minor, use httpx instead of requests, but the devil is in the details. I hope I did not break anything. |
abkfenris
left a comment
There was a problem hiding this comment.
Looks good to me.
I know the change in exceptions will give me issues in my data pipelines, so I'm guessing it may give others problems also, so its probably worth some good consideration when it's released/what version # it gets. Maybe use it as a basis for the refactoring and call the refactoring and httpx v2?
Most of the time httpx performed slightly better for me and have async, which we plan to use soon.