Remove Pandas FutureWarning #229
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Update: just did some more checks and this introduces some bugs. Will investigate further and push to this PR. |
Contributor
Author
|
Fixed with f94c9b8. Had forgotten to overwrite the new |
Member
|
@vinisalazar is this one ready for review? |
Contributor
Author
|
Yes, thank you for the reminder! |
ocefpaf
reviewed
Feb 11, 2022
This removes the Pandas FutureWarning triggered by the use of
frame.append()
Summary of changes:
- Replace `frame.append()` with `pd.concat()`
- Replace `table.index =` with `.set_index(drop=True)`
9440a3b to
e739ff4
Compare
Contributor
Author
|
@ocefapf apologies for missing your comment about the nesting. Thank you for the review and merge! |
Member
|
No problem. I'm doing some housekeeping to get ready for GSoC and went ahead with this one. Hope to see more PRs from you in the future ;-p |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
Problem
When running
ERDDAP.griddap_initialize, I would get the following warning:FutureWarning: The frame.append method is deprecated and will be removed from pandas in a future version. Use pandas.concat instead.My Pandas version is 1.4.0.Proposed solution
If merged, this PR will modify the
_griddap_get_constraintsfunction in order to remove the Pandas FutureWarning that was introduced in the latest Pandas versions.I ran Pytest, Pre-Commit, and tested the function locally (by running
ERDDAP.griddap_initialize), and things seem to be working properly.Summary of changes:
frame.append()withpd.concat()table.index =with.set_index(drop=True)Thank you for any assistance you can provide,
Vini