Skip to content

Update Travis-CI#41

Merged
benjwadams merged 4 commits intoioos:masterfrom
ocefpaf:update_travisci
Oct 13, 2017
Merged

Update Travis-CI#41
benjwadams merged 4 commits intoioos:masterfrom
ocefpaf:update_travisci

Conversation

@ocefpaf
Copy link
Copy Markdown
Member

@ocefpaf ocefpaf commented Oct 13, 2017

Use a test matrix, test the tarball in the install section, remove Python 3.4 and add Python 3.6.

@ghost ghost assigned ocefpaf Oct 13, 2017
ocefpaf
ocefpaf commented Oct 13, 2017
View reviewed changes
Comment thread .travis.yml Outdated
script:
- if [[ $TEST_TARGET == 'default' ]]; then
cp -r cc_plugin_ncei/tests/ /tmp && cd /tmp ;
py.test -s -rxs -v tests ;
Copy link
Copy Markdown
Member Author

@ocefpaf ocefpaf Oct 13, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a "safer" way to run tests b/c that is the condition similar to the user machine, where things are tested from a installed version. I removed it b/c there are a number of failures due to probably hardcoded paths in the tests.

I can fix those later, it is not a big deal.

@ocefpaf
Copy link
Copy Markdown
Member Author

ocefpaf commented Oct 13, 2017

With this change the tests no longer find the cf-standard-name-table.xml, I believe that should come from compliance-checker. I'll take a closer look tomorrow or later today why that happened.

ocefpaf
ocefpaf commented Oct 13, 2017
View reviewed changes
Comment thread .travis.yml
env: TEST_TARGET=coding_standards
allow_failures:
- python: 3.6
env: TEST_TARGET=coding_standards
Copy link
Copy Markdown
Member Author

@ocefpaf ocefpaf Oct 13, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should add to the test matrix a released (default) and latest (allow_failures) version of compliance-checker to catch errors upstream before the releases. I'll modify this PR later today to do that,

@benjwadams
Copy link
Copy Markdown
Contributor

benjwadams commented Oct 13, 2017

@ocefpaf, I ran into this here: 1cc24dc. I'd make a PR on your branch, but it's easy enough to just remove the absolute path. Let me know how you want to proceed.

@ocefpaf
Copy link
Copy Markdown
Member Author

ocefpaf commented Oct 13, 2017

Thanks @benjwadams!

@benjwadams benjwadams merged commit 637ced5 into ioos:master Oct 13, 2017
@ocefpaf ocefpaf deleted the update_travisci branch October 13, 2017 20:44
This was referenced Oct 13, 2017
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@Bobfrat Bobfrat Bobfrat approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@ocefpaf ocefpaf

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ocefpaf @benjwadams @Bobfrat