fix: align config behaviour with terraform#591
Merged
avirtopeanu-ionos merged 9 commits intomasterfrom Sep 23, 2025
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR aligns configuration behavior with Terraform by standardizing product naming and filtering of deprecated APIs to improve consistency across tools. The changes replace hardcoded product names with constants from the fileconfiguration package and update blacklisted products.
- Replace hardcoded product names with fileconfiguration constants across all command files
- Update configuration filtering to blacklist deprecated APIs and rename products for backward compatibility
- Add special handling for monitoring API filtering in code generation
Reviewed Changes
Copilot reviewed 82 out of 82 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| internal/config/generate_from_index.go | Adds filtering logic to ignore old monitoring API during generation |
| commands/cfg/login.go | Updates product name mappings and expands blacklist with deprecated APIs |
| commands/*/*.go | Systematically replaces hardcoded product names with fileconfiguration constants |
| docs/subcommands/CLI Setup/login.md | Updates documentation to reflect new default blacklist values |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
e8716e7 to
f91c868
Compare
…ract-owned-buckets]
f91c868 to
ec1d76b
Compare
|
glimberea
approved these changes
Sep 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stop generating config entry for old
monitoringAPIRename generated config entry and override parsing field
observability-monitoring->monitoring.Keep both names working as overrides for backward compatibility
Stop generating:
object-storage-user-owned-buckets(only generation affected)object-storage-contract-owned-buckets(only generation affected)Renamed products (with backward compatibility where applicable)
vmautoscaling->autoscalingin-memory-db->inmemorydbobject-storage-management->objectstoragemanagement(only generation affected)object-storage->objectstorage(only generation affected)Use
fileconfigurationconstants where possibleBlacklisted unused products (only generation affected)