fix(runtime): place scoped component styles after preconnect links but before custom styles#5938
Merged
christian-bromann merged 5 commits intomainfrom Aug 14, 2024
Merged
Conversation
…t before custom styles
tanner-reits
requested changes
Aug 12, 2024
Contributor
tanner-reits
left a comment
There was a problem hiding this comment.
Tested this out with the failing Framework test and still having the same issue. If there are no preconnect links, can we insert the styles where they were going before (i.e. before the first link tag)?
Member
Author
|
Good catch @tanner-reits , I totally missed that use case but added a change with a test. |
tanner-reits
approved these changes
Aug 13, 2024
Contributor
tanner-reits
left a comment
There was a problem hiding this comment.
Looks good in the Framework test case 👍
Member
Author
|
This patch has been published in Stencil |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the current behavior?
This is an enhancement to a fix we made in in #5926 which caused our Nightly build to fail due to the inability to place custom styles in the HTML template as all component styles were injected last in the
<head />tag.STENCIL-1372
What is the new behavior?
Place scoped component styles after existing preconnect links but allow custom styles to be set at the end of the
<head />tag.Documentation
I will raise a separate PR to the docs page mentioning this behavior.
Does this introduce a breaking change?
Testing
Enhanced existing e2e test.
Other information
n/a