fix: update TypeScript to v5.5#5898
Merged
christian-bromann merged 4 commits intomainfrom Jul 16, 2024
Merged
Conversation
Contributor
|
| Path | Error Count |
|---|---|
| src/dev-server/index.ts | 37 |
| src/dev-server/server-process.ts | 32 |
| src/compiler/prerender/prerender-main.ts | 22 |
| src/runtime/vdom/vdom-render.ts | 22 |
| src/runtime/client-hydrate.ts | 20 |
| src/runtime/vdom/test/patch.spec.ts | 19 |
| src/runtime/vdom/test/util.spec.ts | 19 |
| src/screenshot/connector-base.ts | 19 |
| src/testing/puppeteer/puppeteer-element.ts | 19 |
| src/dev-server/request-handler.ts | 15 |
| src/compiler/prerender/prerender-optimize.ts | 14 |
| src/compiler/sys/stencil-sys.ts | 14 |
| src/runtime/connected-callback.ts | 14 |
| src/sys/node/node-sys.ts | 14 |
| src/compiler/prerender/prerender-queue.ts | 13 |
| src/compiler/sys/in-memory-fs.ts | 13 |
| src/runtime/set-value.ts | 13 |
| src/compiler/output-targets/output-www.ts | 12 |
| src/compiler/transformers/test/parse-vdom.spec.ts | 12 |
| src/compiler/transformers/transform-utils.ts | 12 |
Our most common errors
| Typescript Error Code | Count |
|---|---|
| TS2322 | 338 |
| TS2345 | 327 |
| TS18048 | 188 |
| TS18047 | 99 |
| TS2722 | 27 |
| TS2532 | 21 |
| TS2531 | 19 |
| TS2790 | 11 |
| TS2454 | 10 |
| TS2352 | 9 |
| TS2769 | 8 |
| TS2416 | 7 |
| TS2538 | 4 |
| TS2493 | 3 |
| TS18046 | 2 |
| TS2684 | 1 |
| TS2430 | 1 |
Unused exports report
There are 15 unused exports on this PR. That's the same number of errors on main, so at least we're not creating new ones!
Unused exports
| File | Line | Identifier |
|---|---|---|
| src/runtime/bootstrap-lazy.ts | 22 | setNonce |
| src/screenshot/screenshot-fs.ts | 18 | readScreenshotData |
| src/testing/testing-utils.ts | 198 | withSilentWarn |
| src/utils/index.ts | 145 | CUSTOM |
| src/utils/index.ts | 245 | NODE_TYPES |
| src/utils/index.ts | 269 | normalize |
| src/utils/index.ts | 7 | escapeRegExpSpecialCharacters |
| src/compiler/app-core/app-data.ts | 25 | BUILD |
| src/compiler/app-core/app-data.ts | 116 | Env |
| src/compiler/app-core/app-data.ts | 118 | NAMESPACE |
| src/compiler/fs-watch/fs-watch-rebuild.ts | 123 | updateCacheFromRebuild |
| src/compiler/types/validate-primary-package-output-target.ts | 82 | satisfies |
| src/compiler/types/validate-primary-package-output-target.ts | 82 | Record |
| src/testing/puppeteer/puppeteer-declarations.ts | 496 | WaitForEventOptions |
| src/compiler/sys/fetch/write-fetch-success.ts | 7 | writeFetchSuccessSync |
Contributor
PR built and packed!Download the tarball here: https://github.com/ionic-team/stencil/actions/runs/9963250641/artifacts/1707956766 If your browser saves files to |
Comment on lines
-77
to
-95
| // Here we transform the TypeScript source from a commonjs to an ES module. | ||
| // We do this so that we can add an import from the `@environment` module. | ||
|
|
||
| // trim off the last part that sets module.exports and polyfills globalThis since | ||
| // we don't want typescript to add itself to module.exports when in a node env | ||
| const tsEnding = `if (typeof module !== "undefined" && module.exports) { module.exports = ts; }`; | ||
|
|
||
| if (!code.includes(tsEnding)) { | ||
| throw new Error(`"${tsEnding}" not found`); | ||
| } | ||
| const lastEnding = code.lastIndexOf(tsEnding); | ||
| code = code.slice(0, lastEnding); | ||
|
|
||
| const o: string[] = []; | ||
| o.push(`// TypeScript ${opts.typescriptVersion}`); | ||
| o.push(code); | ||
| o.push(`export default ts;`); | ||
| code = o.join('\n'); | ||
|
|
Contributor
There was a problem hiding this comment.
Just curious, what changed so we don't need this anymore?
Member
Author
There was a problem hiding this comment.
The TypeScript team made changes to make it easier consumable for ESM packages (see announcement). I tested it with an .mjs file, e.g.
import * as foo from './node_modules/typescript/lib/typescript.js'
console.log(foo);And it worked great.
tanner-reits
approved these changes
Jul 16, 2024
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the current behavior?
We currently haven't updated to TypeScript 5.5, this patch enables Renovate to trigger the dep update. Since we lowered the update rate, I went ahead and did the update myself and included it in this PR.
STENCIL-1264
What is the new behavior?
Allow renovate to update to TypeScript 5.5.
Documentation
Does this introduce a breaking change?
Testing
n/a
Other information
n/a