Skip to content

Commit 9cc9ce3

Browse files
rwaskiewiczrwaskiewicz
authored
chore(test): remove strictNullChecks from remove-unused-styles (#4325)
this commit removes a handful of strictNullChecks violations from the tests for `remove-unused-styles`. all fixed violations were caused by an assumptions that the return value of `querySelector` would be non-null. while that is true (since we wrote the tests), it doesn't properly type check.
1 parent c3bcf0a commit 9cc9ce3

1 file changed

Lines changed: 18 additions & 9 deletions

File tree

‎src/compiler/html/test/remove-unused-styles.spec.ts‎

Lines changed: 18 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,8 @@ describe('removeUnusedStyles', () => {
3434

3535
expect(results.diagnostics).toHaveLength(0);
3636

37-
const css = doc.querySelector('style').innerHTML;
37+
// Assert that `querySelector()` will return a value, since we defined the `style` element above.
38+
const css = doc.querySelector('style')!.innerHTML;
3839

3940
expectSelector(css, 'pre[class*="language-"]');
4041
});
@@ -61,7 +62,8 @@ describe('removeUnusedStyles', () => {
6162

6263
expect(results.diagnostics).toHaveLength(0);
6364

64-
const css = doc.querySelector('style').innerHTML;
65+
// Assert that `querySelector()` will return a value, since we defined the `style` element above.
66+
const css = doc.querySelector('style')!.innerHTML;
6567

6668
expectSelector(css, '[dir="ltr"] h1+h2');
6769
expectNoSelector(css, '[dir="ltr"] h1+h3');
@@ -90,7 +92,8 @@ describe('removeUnusedStyles', () => {
9092

9193
expect(results.diagnostics).toHaveLength(0);
9294

93-
const css = doc.querySelector('style').innerHTML;
95+
// Assert that `querySelector()` will return a value, since we defined the `style` element above.
96+
const css = doc.querySelector('style')!.innerHTML;
9497

9598
expectNoSelector(css, 'label { font: used; }');
9699
expectNoSelector(css, 'div label { font: used; }');
@@ -124,7 +127,8 @@ describe('removeUnusedStyles', () => {
124127

125128
expect(results.diagnostics).toHaveLength(0);
126129

127-
const css = doc.querySelector('style').innerHTML;
130+
// Assert that `querySelector()` will return a value, since we defined the `style` element above.
131+
const css = doc.querySelector('style')!.innerHTML;
128132

129133
expectSelector(css, 'div{font:used}');
130134
expectSelector(css, 'label{font:used}');
@@ -159,7 +163,8 @@ describe('removeUnusedStyles', () => {
159163

160164
expect(results.diagnostics).toHaveLength(0);
161165

162-
const css = doc.querySelector('style').innerHTML;
166+
// Assert that `querySelector()` will return a value, since we defined the `style` element above.
167+
const css = doc.querySelector('style')!.innerHTML;
163168

164169
expectSelector(css, 'label{font:used}');
165170
expectSelector(css, 'label#usedId');
@@ -188,7 +193,8 @@ describe('removeUnusedStyles', () => {
188193

189194
expect(results.diagnostics).toHaveLength(0);
190195

191-
const css = doc.querySelector('style').innerHTML;
196+
// Assert that `querySelector()` will return a value, since we defined the `style` element above.
197+
const css = doc.querySelector('style')!.innerHTML;
192198

193199
expectSelector(css, 'label{font:used}');
194200
expectSelector(css, 'label[mph="88"]');
@@ -214,7 +220,8 @@ describe('removeUnusedStyles', () => {
214220

215221
expect(results.diagnostics).toHaveLength(0);
216222

217-
const css = doc.querySelector('style').innerHTML;
223+
// Assert that `querySelector()` will return a value, since we defined the `style` element above.
224+
const css = doc.querySelector('style')!.innerHTML;
218225

219226
expectSelector(css, 'label');
220227
expectNoSelector(css, 'div');
@@ -239,7 +246,8 @@ describe('removeUnusedStyles', () => {
239246

240247
expect(results.diagnostics).toHaveLength(0);
241248

242-
const css = doc.querySelector('style').innerHTML;
249+
// Assert that `querySelector()` will return a value, since we defined the `style` element above.
250+
const css = doc.querySelector('style')!.innerHTML;
243251

244252
expectSelector(css, '.used-class');
245253
expectNoSelector(css, '.unused-class');
@@ -265,7 +273,8 @@ describe('removeUnusedStyles', () => {
265273

266274
expect(results.diagnostics).toHaveLength(0);
267275

268-
const css = doc.querySelector('style').innerHTML;
276+
// Assert that `querySelector()` will return a value, since we defined the `style` element above.
277+
const css = doc.querySelector('style')!.innerHTML;
269278

270279
expectSelector(css, '.used-class');
271280
expectNoSelector(css, '.unused-class');

0 commit comments

Comments
 (0)