fix(vdom): properly warn for step attr on input (#3196)

rwaskiewicz · web-flow · commit 7ffc02e5d07b · 2021-12-29T10:00:54.000-05:00
fix `indexOf` call for the step attribute to look for the correct
attribute name.

hoist the check for `value` attribute to exit early if the attribute
does not exist, avoiding unneeded lookups of other attributes

STENCIL-79: Fix typo on &lt;input&gt; attribute validations
diff --git a/src/runtime/vdom/h.ts b/src/runtime/vdom/h.ts
@@ -163,16 +163,22 @@ const convertToPrivate = (node: d.ChildNode): d.VNode => {
   return vnode;
 };
 
-const validateInputProperties = (vnodeData: any) => {
-  const props = Object.keys(vnodeData);
-  const typeIndex = props.indexOf('type');
-  const minIndex = props.indexOf('min');
-  const maxIndex = props.indexOf('max');
-  const stepIndex = props.indexOf('min');
+/**
+ * Validates the ordering of attributes on an input element
+ * @param inputElm the element to validate
+ */
+const validateInputProperties = (inputElm: HTMLInputElement): void => {
+  const props = Object.keys(inputElm);
+
   const value = props.indexOf('value');
   if (value === -1) {
     return;
   }
+
+  const typeIndex = props.indexOf('type');
+  const minIndex = props.indexOf('min');
+  const maxIndex = props.indexOf('max');
+  const stepIndex = props.indexOf('step');
   if (value < typeIndex || value < minIndex || value < maxIndex || value < stepIndex) {
     consoleDevWarn(`The "value" prop of <input> should be set after "min", "max", "type" and "step"`);
   }
