fix: update TypeScript to v5.5 (#5898)

christian-bromann · web-flow · commit 5e748378fd14 · 2024-07-16T22:17:54.000Z
* chore: bump typescript version in renovate.json to &lt;5.6.0

* chore: update TS to 5.5

* prettier

* remove console.log
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -181,7 +181,7 @@
     "semver": "^7.3.7",
     "terser": "5.31.1",
     "tsx": "^4.10.3",
-    "typescript": "~5.4.0",
+    "typescript": "~5.5.3",
     "webpack": "^5.75.0",
     "ws": "8.17.1"
   },
diff --git a/renovate.json5 b/renovate.json5
@@ -57,7 +57,7 @@
     {
       // Increment this value as a part of updating TypeScript
       matchPackageNames: ['typescript'],
-      allowedVersions: '<5.5.0',
+      allowedVersions: '<5.6.0',
       commitMessagePrefix: "feat(typescript):"
     },
     {
@@ -152,7 +152,7 @@
   rebaseWhen: 'never',
   /**
    * Cron syntax to run at midnight (UTC) on the first day of every month
-   * 
+   *
    * Note: Renovate does not support minute value granularity, so the wildcard value is necessary
    */
   schedule: ["* 0 1 * *"],
diff --git a/scripts/esbuild/utils/typescript-source.ts b/scripts/esbuild/utils/typescript-source.ts
@@ -74,25 +74,6 @@ export async function bundleTypeScriptSource(tsPath: string, opts: BuildOptions)
   const jestTypesciptFilename = join(opts.scriptsBuildDir, 'typescript-modified-for-jest.js');
   await fs.writeFile(jestTypesciptFilename, code);
 
-  // Here we transform the TypeScript source from a commonjs to an ES module.
-  // We do this so that we can add an import from the `@environment` module.
-
-  // trim off the last part that sets module.exports and polyfills globalThis since
-  // we don't want typescript to add itself to module.exports when in a node env
-  const tsEnding = `if (typeof module !== "undefined" && module.exports) { module.exports = ts; }`;
-
-  if (!code.includes(tsEnding)) {
-    throw new Error(`"${tsEnding}" not found`);
-  }
-  const lastEnding = code.lastIndexOf(tsEnding);
-  code = code.slice(0, lastEnding);
-
-  const o: string[] = [];
-  o.push(`// TypeScript ${opts.typescriptVersion}`);
-  o.push(code);
-  o.push(`export default ts;`);
-  code = o.join('\n');
-
   // TODO(STENCIL-839): investigate minification issue w/ typescript 5.0
   // const { minify } = await import('terser');
 
diff --git a/src/runtime/proxy-component.ts b/src/runtime/proxy-component.ts
@@ -154,7 +154,8 @@ export const proxyComponent = (
           } else if (
             prototype.hasOwnProperty(propName) &&
             typeof this[propName] === 'number' &&
-            this[propName] == newValue
+            // cast type to number to avoid TS compiler issues
+            this[propName] == (newValue as unknown as number)
           ) {
             // if the propName exists on the prototype of `Cstr`, this update may be a result of Stencil using native
             // APIs to reflect props as attributes. Calls to `setAttribute(someElement, propName)` will result in
diff --git a/test/end-to-end/package-lock.json b/test/end-to-end/package-lock.json
