chore(test): fix worker-manager snc violations (#4326)

rwaskiewicz · web-flow · commit 4ab9083e33af · 2023-04-28T20:54:00.000Z
this commit fixes two types of violations that were found in
`worker-manager.spec.ts`:

1. check that the returned worker exists before running assertions on
   it
2. stubs for worker tasks cannot be `null` - instead provide a proper
   stub that conforms to the interface (only providing required fields)
diff --git a/src/sys/node/test/worker-manager.spec.ts b/src/sys/node/test/worker-manager.spec.ts
@@ -1,10 +1,18 @@
+import type * as d from '../../../declarations';
 import { getNextWorker } from '../node-worker-controller';
 import { TestWorkerMain } from './test-worker-main';
 
 describe('getNextWorker', () => {
   let workers: TestWorkerMain[];
   const maxConcurrentWorkers = 4;
 
+  const stubCompilerWorkerTask = (): d.CompilerWorkerTask => {
+    return {
+      resolve: () => {},
+      reject: () => {},
+    };
+  };
+
   beforeEach(() => {
     workers = [];
     for (let i = 0; i < maxConcurrentWorkers; i++) {
@@ -14,55 +22,60 @@ describe('getNextWorker', () => {
   });
 
   it('get worker with fewest total tasks assigned when all the same number of tasks', () => {
-    workers[0].tasks.set(1, null);
-    workers[0].tasks.set(2, null);
-    workers[0].tasks.set(3, null);
+    workers[0].tasks.set(1, stubCompilerWorkerTask());
+    workers[0].tasks.set(2, stubCompilerWorkerTask());
+    workers[0].tasks.set(3, stubCompilerWorkerTask());
     workers[0].totalTasksAssigned = 50;
 
-    workers[1].tasks.set(1, null);
-    workers[1].tasks.set(2, null);
-    workers[1].tasks.set(3, null);
+    workers[1].tasks.set(1, stubCompilerWorkerTask());
+    workers[1].tasks.set(2, stubCompilerWorkerTask());
+    workers[1].tasks.set(3, stubCompilerWorkerTask());
     workers[1].totalTasksAssigned = 40;
 
     // this one is tied for fewest active tasks (3)
     // but has the fewest total tasks assigned (30)
-    workers[2].tasks.set(1, null);
-    workers[2].tasks.set(2, null);
-    workers[2].tasks.set(3, null);
+    workers[2].tasks.set(1, stubCompilerWorkerTask());
+    workers[2].tasks.set(2, stubCompilerWorkerTask());
+    workers[2].tasks.set(3, stubCompilerWorkerTask());
     workers[2].totalTasksAssigned = 30;
 
-    workers[3].tasks.set(1, null);
-    workers[3].tasks.set(2, null);
-    workers[3].tasks.set(3, null);
-    workers[3].tasks.set(4, null);
-    workers[3].tasks.set(5, null);
+    workers[3].tasks.set(1, stubCompilerWorkerTask());
+    workers[3].tasks.set(2, stubCompilerWorkerTask());
+    workers[3].tasks.set(3, stubCompilerWorkerTask());
+    workers[3].tasks.set(4, stubCompilerWorkerTask());
+    workers[3].tasks.set(5, stubCompilerWorkerTask());
     workers[3].totalTasksAssigned = 20;
 
     const w = getNextWorker(workers);
-    expect(w.id).toBe(2);
+
+    expect(w).toBeDefined();
+    expect(w!.id).toBe(2);
   });
 
   it('get first worker when all the same', () => {
-    workers[0].tasks.set(1, null);
+    workers[0].tasks.set(1, stubCompilerWorkerTask());
     workers[0].totalTasksAssigned = 1;
-    workers[1].tasks.set(1, null);
+    workers[1].tasks.set(1, stubCompilerWorkerTask());
     workers[1].totalTasksAssigned = 1;
-    workers[2].tasks.set(1, null);
+    workers[2].tasks.set(1, stubCompilerWorkerTask());
     workers[2].totalTasksAssigned = 1;
-    workers[3].tasks.set(1, null);
+    workers[3].tasks.set(1, stubCompilerWorkerTask());
     workers[3].totalTasksAssigned = 1;
 
     const w = getNextWorker(workers);
-    expect(w.id).toBe(0);
+
+    expect(w).toBeDefined();
+    expect(w!.id).toBe(0);
   });
 
   it('forth task', () => {
-    workers[0].tasks.set(1, null);
-    workers[1].tasks.set(1, null);
-    workers[2].tasks.set(1, null);
+    workers[0].tasks.set(1, stubCompilerWorkerTask());
+    workers[1].tasks.set(1, stubCompilerWorkerTask());
+    workers[2].tasks.set(1, stubCompilerWorkerTask());
 
     const w = getNextWorker(workers);
 
-    expect(w.id).toBe(3);
+    expect(w).toBeDefined();
+    expect(w!.id).toBe(3);
   });
 });
