fix(datetime): display today's date and time when value is an empty string #29839
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
tanner-reits
suggested changes
Sep 6, 2024
Contributor
tanner-reits
left a comment
There was a problem hiding this comment.
One suggestion, otherwise looks good!
Co-authored-by: Tanner Reits <47483144+tanner-reits@users.noreply.github.com>
tanner-reits
approved these changes
Sep 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number: resolves #29669
What is the current behavior?
Setting
valueto an empty string on<ion-datetime>renders a May 2021 calendar:What is the new behavior?
Show the month and time for today's date when value is an empty string. This matches how a native
inputwithtype="datetime-local"works.Does this introduce a breaking change?
Other information
This can be tested by removing my fix in
datetime.tsxand running the e2e test for Datetime:The
should display today's date and time when value is an empty stringtest should fail.Alternatively, you can add a datetime with
value=""and see the calendar before & after my fix.