fix(test): fix Stencil Nightly build#29780
Merged
christian-bromann merged 1 commit intomainfrom Aug 20, 2024
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
brandyscarney
approved these changes
Aug 20, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the current behavior?
The Playwright test for
core/src/components/menu/test/safe-area/menu.e2e.tsstarted to fail after introducing the following patch to Stencil: #5926. After debugging the situation it turns out that the test overwrites the first style in the<head />tag which turns out to be a component style that caused all screenshot test to fail.What is the new behavior?
Overwrite the existing style by adding a new style tag at the bottom of the page.
Does this introduce a breaking change?
Other information
n/a