Skip to content

chore(deps): update dependency @stencil/core to v4.19.2#29685

Merged
brandyscarney merged 1 commit intomainfrom
chore-deps-stencil-4.19.2
Jul 2, 2024
Merged

chore(deps): update dependency @stencil/core to v4.19.2#29685
brandyscarney merged 1 commit intomainfrom
chore-deps-stencil-4.19.2

Conversation

@brandyscarney
Copy link
Copy Markdown
Member

@brandyscarney brandyscarney commented Jul 2, 2024 •
edited
Loading

Issue number: resolves #29681

Release Notes

ionic-team/stencil (@​stencil/core)

v4.19.2

Compare Source

Bug Fixes

@brandyscarney brandyscarney requested a review from a team as a code owner July 2, 2024 20:41
@brandyscarney brandyscarney requested a review from gnbm July 2, 2024 20:41
@vercel
Copy link
Copy Markdown

vercel Bot commented Jul 2, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ionic-framework ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 2, 2024 8:43pm

@github-actions github-actions Bot added the package: core @ionic/core package label Jul 2, 2024
@brandyscarney brandyscarney changed the title chore(deps): update @stencil/core chore(deps): update dependency @stencil/core to 4.19.2 Jul 2, 2024
@brandyscarney brandyscarney changed the title chore(deps): update dependency @stencil/core to 4.19.2 chore(deps): update dependency @stencil/core to v4.19.2 Jul 2, 2024
sean-perkins
sean-perkins approved these changes Jul 2, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@sean-perkins sean-perkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would add resolves #29681 to the PR description and then this is good to merge.

@brandyscarney
Copy link
Copy Markdown
Member Author

brandyscarney commented Jul 2, 2024

I will still have to manually add it to the changelog due to the chore, if desired

@brandyscarney brandyscarney enabled auto-merge July 2, 2024 21:01
thetaPC
thetaPC approved these changes Jul 2, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@thetaPC thetaPC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@brandyscarney brandyscarney added this pull request to the merge queue Jul 2, 2024
Merged via the queue into main with commit d70ea40 Jul 2, 2024
@brandyscarney brandyscarney deleted the chore-deps-stencil-4.19.2 branch July 2, 2024 21:13
@vinnivitz vinnivitz mentioned this pull request Jul 27, 2024
Open
@vinnivitz vinnivitz mentioned this pull request Aug 15, 2024
Open
This was referenced Aug 25, 2024
Open
Open
@vinnivitz vinnivitz mentioned this pull request Sep 4, 2024
Merged
This was referenced Sep 21, 2024
Open
Open
@bdr0id bdr0id mentioned this pull request Oct 26, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@thetaPC thetaPC thetaPC approved these changes

@gnbm gnbm Awaiting requested review from gnbm gnbm is a code owner automatically assigned from ionic-team/framework

+1 more reviewer

@sean-perkins sean-perkins sean-perkins approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

package: core @ionic/core package

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

bug: DOMException: Failed to execute 'insertBefore' on 'Node' bug: Broken exports for testing bug: hydrate crashes if component uses @Listen

3 participants

@brandyscarney @thetaPC @sean-perkins