fix(angular): set active segment button when dynamically changing items #29418
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
jakobe
approved these changes
Apr 30, 2024
Contributor
jakobe
left a comment
There was a problem hiding this comment.
I can confirm this fixes the mentioned issue 👍🏻
thetaPC
reviewed
Apr 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number: resolves #29414
What is the current behavior?
In Angular when the segment buttons are dynamically rendered, the segment will not set the active visual state for the selected segment after the re-render.
What is the new behavior?
Previously this PR: #28837 aimed to resolve #28816. I have confirmed that the modified approach in the dev-build fixes #29414 and #28816 and the previous change is no longer needed.
Does this introduce a breaking change?
Other information
Dev-build:
8.0.2-dev.11714411675.10f48160