fix(loading): spinner now respects —spinner-color#25261
Conversation
averyjohnston
left a comment
There was a problem hiding this comment.
Would it be possible to add a timeout or something so the loading spinner is more visible in the screenshots? I worry that if this does regress in the future, it'll be hard to tell what's going on. 🤔
Also, one of the popover screenshots got updated and the popover is now missing; looks like that test might be flaky?
|
That's the initial state of the spinner -- all of the spinners are paused by default so they won't be running. Adding a timeout won't change how the spinner is rendered as a result. I can try changing it to another spinner that has more visible in the initial state. |
|
re: popover screenshots: that looks like FW-1397. Let me take a look and see if I can fix it. |
|
Ok I did a couple things:
|
|
Much better, thanks! |
Pull request checklist
Please check if your PR fulfills the following requirements:
npm run build) was run locally and any changes were pushednpm run lint) has passed locally and any fixes were made for failuresPull request type
Please check the type of change your PR introduces:
What is the current behavior?
Issue URL: resolves #25180
What is the new behavior?
Does this introduce a breaking change?
Other information
Note: Rather than add another test for this specific usage, I updated the existing test to account for this new behavior.