Fix extension host crash when used with GitHub Copilot #49
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The pollution of Object.prototype.toBuffer breaks other vscode extensions
Collaborator
|
Awesome, thanks! |
Contributor
Author
|
Thanks for the fast merge @mrexodia! Could you update the extension on vscode marketplace too? |
Collaborator
|
Unfortunately I do not have access to the extension store CC @ioncodes |
Owner
|
I'll update it today, thanks! EDIT: Looks like this might take a while. Something seems to be wrong with my Microsoft account, sent support an email. |
Owner
|
Done! Huge thanks to the both of you <3 Just made an official release both as GitHub Release and VSIX update on the VS Code marketplace! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
idacode/src/extension.tsfile pollutes the global JavaScript object prototype:This causes some vscode extensions (eg GitHub Copilot) to malfunction.
I have rewritten this method as a regular function, which allows both extensions to be used at the same time with no change in behavior.