inibitset: include pycore_frame for py 3.11#82
Conversation
this is a backport of a change done in cython to include the correct definition of PyFrame for python 3.11. Only added a guard macro to avoid double including the header file Closes inveniosoftware-contrib#81 Signed-off-by: Konrad Weihmann <kweihmann@outlook.com>
|
A test case would be to compile with py3.10 and py3.11 in CI (currently that is only given up to py3.9) - if that is necessary to get it merged, I will add that to this PR or a new one |
|
Thanks you ++
It is not in this case, and it would suffice IMHO to add 3.11 to the test matrix in https://github.com/inveniosoftware/intbitset/blob/master/.github/workflows/test-and-build.yml ? |
|
@priv-kweihmann your fix is sleek ... but the C code would be overwritten when regenerated? |
|
@pombredanne surely it will be - but I'm not sure when cython project finally will release something that is compatible with py3.11 - currently one would have to used the master to regenerate. |
|
@priv-kweihmann we can merge this now and also add an issue with your patch attached so we can also handle in the future |
|
Merging now |
|
I wonder when this is going to be fixed upstream @priv-kweihmann do you know? |
|
@pombredanne I'm not involved with cython upstream, so I don't know, but I'm waiting as everyone else on a release that officially supports py 3.11 |
this is a backport of a change done in cython to include the correct definition of PyFrame for python 3.11.
Only added a guard macro to avoid double including the header file.
Ticks in all boxes and 🟢 on all GitHub actions status checks are required to merge:
Third-party code
If you've added third-party code (copy/pasted or new dependencies), please reach out to an architect.
Reminder
By using GitHub, you have already agreed to the GitHub’s Terms of Service including that: