make compilation compatible with other platform than x86#75
Merged
pombredanne merged 1 commit intoinveniosoftware-contrib:masterfrom Apr 6, 2021
Merged
make compilation compatible with other platform than x86#75pombredanne merged 1 commit intoinveniosoftware-contrib:masterfrom
pombredanne merged 1 commit intoinveniosoftware-contrib:masterfrom
Conversation
Signed-off-by: Pierre Tardy <pierre.tardy@renault.com>
Collaborator
|
@tardyp thank you ++ |
Collaborator
We should remove them then IMHO, what do you think? |
Collaborator
|
I am merging this now, but if they bring nothing, let's remove the complexity. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix: #74
franckly, I am not sure if those compile_args are really necessary.
I would personally let the python implementation define the default sweetable for the platform.
I am not sure what can be taken as a performance benchmark, but on my x86 test VM, difference with default compile args is not significative.
24.06s with default versus 24.12s with optimisations (sic)