Pull SSO client secret from SSM#310
Merged
Zakaria-Kofiro merged 9 commits intomasterfrom Mar 21, 2024
Merged
Conversation
| LOG.info("Error retrieving client secret from SSM", e); | ||
| } | ||
| } | ||
| return oidcSsoConfig.getClientSecret(); |
Collaborator
There was a problem hiding this comment.
Can you return clientKey rather than looking it up again?
kevin-mcgoldrick
approved these changes
Mar 21, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull SSO client secret from SSM
Adds option to store client secret in SSM to be pulled on SSO login - returns the default value for client secret key from
settings.xmlfile if set to value not matching SSM key path (/*)Please make sure these check boxes are checked before submitting
mvn clean test -P default** PR review process **