Skip to content

Script Groups: Add Selected scripts to script list in correct order#270

Merged
Zakaria-Kofiro merged 2 commits intomasterfrom
zkofiro/script-group-order
Sep 28, 2023
Merged

Script Groups: Add Selected scripts to script list in correct order#270
Zakaria-Kofiro merged 2 commits intomasterfrom
zkofiro/script-group-order

Conversation

@Zakaria-Kofiro
Copy link
Collaborator

@Zakaria-Kofiro Zakaria-Kofiro commented Sep 26, 2023

Script Groups: Add Selected scripts to script list in correct order

This PR fixes a bug where under Script Groups, Selected scripts are being added to the list of project scripts in inverse order such that the last selected script becomes the first script added. This has been changed such that Selected scripts are added to the list of project scripts in the order they are selected.

Please make sure these check boxes are checked before submitting

  • ** Squashed Commits **
  • ** All Tests Passed ** - mvn clean test -P default

** PR review process **

  • Requires one +1 from a reviewer
  • Repository owners will merge your PR once it is approved.

@Zakaria-Kofiro Zakaria-Kofiro changed the title add scripts in correct order Script Groups: Add Selected scripts to script list in correct order Sep 26, 2023
@Zakaria-Kofiro Zakaria-Kofiro marked this pull request as ready for review September 26, 2023 22:09
Copy link
Collaborator

@kevin-mcgoldrick kevin-mcgoldrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Zakaria-Kofiro Zakaria-Kofiro merged commit b213c96 into master Sep 28, 2023
@Zakaria-Kofiro Zakaria-Kofiro deleted the zkofiro/script-group-order branch September 28, 2023 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants