Skip to content

Tag Agents at Creation Time#267

Merged
kevin-mcgoldrick merged 2 commits intomasterfrom
TagEC2onCreation
Sep 13, 2023
Merged

Tag Agents at Creation Time#267
kevin-mcgoldrick merged 2 commits intomasterfrom
TagEC2onCreation

Conversation

@kevin-mcgoldrick
Copy link
Collaborator

Tag Agents at Creation Time

  • Remved tagInstance method (after creation)
  • Added tagSpecifications to runInstancesRequestTemplate to tag during build time
  • Change DataConverter to static methods
  • Updated DataConverter Tests

Please make sure these check boxes are checked before submitting

  • ** Squashed Commits **
  • ** All Tests Passed ** - mvn clean test -P default

** PR review process **

  • Requires one +1 from a reviewer
  • Repository owners will merge your PR once it is approved.

Copy link
Collaborator

@Zakaria-Kofiro Zakaria-Kofiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kevin-mcgoldrick kevin-mcgoldrick merged commit 70bdb3b into master Sep 13, 2023
@kevin-mcgoldrick kevin-mcgoldrick deleted the TagEC2onCreation branch September 13, 2023 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants