V2 apply filter and upload script fix #249
Merged
Zakaria-Kofiro merged 4 commits intomasterfrom Jul 6, 2023
Merged
Conversation
kevin-mcgoldrick
approved these changes
Jul 6, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
title: - V2 apply filter + upload script fix
This PR includes changes to the
apply-filtersendpoint to alsosetScriptStepLabels. This allows the endpoint to not only apply filter and filter groups but also update the script step labels after filters are applied as the UI does. Theapplication.ymlhas also been updated with a max file and request size of 200MB to avoid any max file upload errors.Please make sure these check boxes are checked before submitting
mvn clean test -P default** PR review process **