Tank API Version 2.0 Implementation Release #234
Merged
Zakaria-Kofiro merged 1 commit intomasterfrom Mar 17, 2023
Merged
Conversation
shawn-h-park
reviewed
Mar 7, 2023
rest-mvc/src/main/java/com/intuit/tank/rest/mvc/rest/services/agent/AgentServiceV2Impl.java
Show resolved
Hide resolved
shawn-h-park
requested changes
Mar 7, 2023
rest-mvc/src/main/java/com/intuit/tank/rest/mvc/rest/services/agent/AgentServiceV2Impl.java
Outdated
Show resolved
Hide resolved
rest-mvc/src/main/java/com/intuit/tank/rest/mvc/rest/services/agent/AgentServiceV2Impl.java
Show resolved
Hide resolved
rest-mvc/src/main/java/com/intuit/tank/rest/mvc/rest/controllers/FilterController.java
Outdated
Show resolved
Hide resolved
rest-mvc/src/main/java/com/intuit/tank/rest/mvc/rest/controllers/JobController.java
Outdated
Show resolved
Hide resolved
rest-mvc/src/main/java/com/intuit/tank/rest/mvc/rest/services/jobs/JobServiceV2.java
Outdated
Show resolved
Hide resolved
...-mvc/src/main/java/com/intuit/tank/rest/mvc/rest/services/projects/ProjectServiceV2Impl.java
Outdated
Show resolved
Hide resolved
rest-mvc/src/main/java/com/intuit/tank/rest/mvc/rest/controllers/ScriptController.java
Outdated
Show resolved
Hide resolved
rest-mvc/src/main/java/com/intuit/tank/rest/mvc/rest/services/scripts/ScriptServiceV2.java
Outdated
Show resolved
Hide resolved
rest-mvc/src/main/java/com/intuit/tank/rest/mvc/rest/services/scripts/ScriptServiceV2Impl.java
Outdated
Show resolved
Hide resolved
| @@ -11,7 +11,7 @@ | |||
| import com.intuit.tank.vm.agent.messages.AgentTestStartData; | |||
| import com.intuit.tank.vm.agent.messages.AgentData; | |||
| import com.intuit.tank.api.model.v1.cloud.CloudVmStatus; | |||
Contributor
There was a problem hiding this comment.
Collaborator
Author
There was a problem hiding this comment.
Fixed: Import is referencing the right data model, it's returned by V1 CloudController which Agent Service still depends on for agent instance operations. Replicating JobController and CloudController caused a lot of issues in job/agent instance operations, so they are the only V1 references left, and will be moved over as V1 is sunset.
Removed the unused data models to be replaced with new data models in future PR.
shawn-h-park
approved these changes
Mar 17, 2023
kevin-mcgoldrick
approved these changes
Mar 17, 2023
fix: resources and tests not needed on remote yet feat: Tank V2 API Main Routes Done/QA Validation fix: clean up and fixing deps fix: removing tests fix: updating application.yml feat: New routes + changes to config fix: commenting out failing test for now to test endpoints fix: fixing port feat: final resources config feat: new routes + clean up feat: Added project update endpoint, final tests, and documentation Updating documentation, removing unneeded script update, and fixing tests feat: Added workloadType and terminationPolicy to project payload + cleaned up docs feat: fleshed out project, job, script payload + example values, updated ns + swagger UI feat: Updating dependencies and removing unneeded job route (group by project) fix: should fix the try it out in swagger ui fix: reverting namespaces, updating pauseRamp and resumeRamp to pause and resume fix: removing unused tests fix: updated parent pom fix: should fix jackson databind and servlet errors feat: updated location header, agent/job error codes, api docs link to swagger Moved data models + util files from V1 to V2, updated pom fix: reverting depr msgs (sunsetting V1 as a whole) + formatting fix: formatting fix: final formatting feat: Add datafile service and tests to V2, cleaned up imports + documentation fix: /datafiles/content now correctly applies offset if no numlines provided Updated request body and resource deletion exception handling, cleaned up poms and swagger docs formatting + new lines fix: removing cloudvmstatus models for now small QOL changes to swagger ui
15caf36 to
dda49fa
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tank API Version 2.0 Implementation Release
Please make sure these check boxes are checked before submitting
mvn clean test -P default** PR review process **