fix bigobj under MSVC, fix yaml-cpp link.#957
Merged
matlabbe merged 1 commit intointrolab:masterfrom Jan 21, 2023
Merged
Conversation
Member
|
Thanks! |
Member
|
I checked the old msvc build, and For yaml-cpp, maybe it is because on how vcpkg builds its own version of yaml-cpp (without old cmake include/library variables). The windows build seems now including two times the yaml-cpp library: This doesn't affect the build either, so lets keep it for vcpkg. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
/bigobjto compileyaml-cpp, as thefind_packagedoesn't setYAML_CPP_INCLUDE_DIRSandYAML_CPP_LIBRARIES(undervcpkg, at least), which failed to link. This patch linkyaml-cppdirectly.