Skip to content

fix bigobj under MSVC, fix yaml-cpp link.#957

Merged
matlabbe merged 1 commit intointrolab:masterfrom
reitowo:update-opencv47
Jan 21, 2023
Merged

fix bigobj under MSVC, fix yaml-cpp link.#957
matlabbe merged 1 commit intointrolab:masterfrom
reitowo:update-opencv47

Conversation

@reitowo
Copy link
Copy Markdown
Contributor

@reitowo reitowo commented Jan 20, 2023

  • MSVC needs /bigobj to compile
  • The original cmake file failed to link yaml-cpp, as the find_package doesn't set YAML_CPP_INCLUDE_DIRS and YAML_CPP_LIBRARIES (under vcpkg, at least), which failed to link. This patch link yaml-cpp directly.

@matlabbe matlabbe merged commit 40ab330 into introlab:master Jan 21, 2023
@matlabbe
Copy link
Copy Markdown
Member

Thanks!

@matlabbe
Copy link
Copy Markdown
Member

matlabbe commented Jan 22, 2023

I checked the old msvc build, and /bigobj seems not used and worked. I remember though on some computer config it is required. Having the flag doesn't seem to cause build issue, I'll keep it.

For yaml-cpp, maybe it is because on how vcpkg builds its own version of yaml-cpp (without old cmake include/library variables). The windows build seems now including two times the yaml-cpp library:

"C:\Program Files\yaml-cpp\lib\libyaml-cppmd.lib" "C:\Program Files\yaml-cpp\lib\libyaml-cppmd.lib"

This doesn't affect the build either, so lets keep it for vcpkg.

@reitowo reitowo deleted the update-opencv47 branch January 22, 2023 03:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants