Skip to content

VINS Fusion overhaul#1580

Merged
matlabbe merged 2 commits intomasterfrom
vins_fusion_overhaul
Sep 15, 2025
Merged

VINS Fusion overhaul#1580
matlabbe merged 2 commits intomasterfrom
vins_fusion_overhaul

Conversation

@matlabbe
Copy link
Copy Markdown
Member

@matlabbe matlabbe commented Sep 15, 2025

  • Updated compatible patch to put over this PR136: https://gist.github.com/matlabbe/795ab37067367dca58bbadd8201d986c

    • Install VINS-Fusion:
      cd ~/catkin_ws/src
      git clone https://github.com/HKUST-Aerial-Robotics/VINS-Fusion.git
      cd VINS-Fusion
      git fetch origin pull/136/head:noetic_fix
      git checkout noetic_fix
      wget https://gist.githubusercontent.com/matlabbe/795ab37067367dca58bbadd8201d986c/raw/193453344b0e35d3b0156a763699d7976474d928/vins-fusion_pull136.patch
      git apply vins-fusion_pull136.patch
      
  • FOCAL_LENGTH was hard-coded to 460 inside VINS repo, now it is adjusted based on current camera calibration. It requires the patch above or you will get an error like this:

    • /home/vscode/catkin_ws/rtabmap/corelib/src/odometry/OdometryVINSFusion.cpp: In constructor ‘rtabmap::VinsFusionEstimator::VinsFusionEstimator(const rtabmap::Transform&, const rtabmap::StereoCameraModel&, bool)’: /home/vscode/catkin_ws/rtabmap/corelib/src/odometry/OdometryVINSFusion.cpp:90:17: error: assignment of read-only variable ‘FOCAL_LENGTH’ 90 | FOCAL_LENGTH = params.fx();
  • Updated visualization, the dots in Image View follows better the image and we show the tracked features.

  • Renamed OdometryVINS to OdometryVINSFusion to be less confusing with other approaches containing VINS too.

    • With cmake, use cmake -DWITH_VINS_FUSION=ON (backward compatible if you still use -DWITH_VINS=ON)
    • Renamed parameter OdomVINS/ConfigPath to OdomVINSFusion/ConfigPath (backward compatible if you still use old name, a warning will be shown).

Tested inside docker ubuntu 20.04 + Noetic using euroc_datasets.launch.

Peek.2025-09-14.18-05.mp4

@matlabbe matlabbe merged commit cb0cc9e into master Sep 15, 2025
7 checks passed
@matlabbe matlabbe deleted the vins_fusion_overhaul branch September 25, 2025 23:28
@lifafang
Copy link
Copy Markdown

How should I proceed with ROS 2 Humble? How do I install VINS-Fusion for use with rtabmap? @matlabbe

@matlabbe
Copy link
Copy Markdown
Member Author

matlabbe commented Nov 1, 2025

See #1598 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants