fixed ORB_SLAM preproc breaking gui conditionals#1445
Merged
matlabbe merged 1 commit intointrolab:masterfrom Feb 4, 2025
Merged
fixed ORB_SLAM preproc breaking gui conditionals#1445matlabbe merged 1 commit intointrolab:masterfrom
matlabbe merged 1 commit intointrolab:masterfrom
Conversation
Member
|
Looks like that commit 97c5636#diff-7282862b01571b1485f94b60c0e593f502fff1cd2d4fe04c14ed633225242cdb broke it. Thanks for the fix! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
setting RTABMAP_ORB_SLAM true would put the if statements all out of whack in the perferences dialog:
/home/grover/vision_dev/rtabmap/guilib/src/PreferencesDialog.cpp: In member function ‘void rtabmap::PreferencesDialog::setParameter(const string&, const string&)’: /home/grover/vision_dev/rtabmap/guilib/src/PreferencesDialog.cpp:4904:7: error: expected ‘}’ before ‘else’ 4904 | else | ^~~~ /home/grover/vision_dev/rtabmap/guilib/src/PreferencesDialog.cpp:4894:6: note: to match this ‘{’ 4894 | { | ^There may be a cleaner way to do it, but his fixed my build