Update iOS app's install_deps.sh to remove PCL's SSE dependency#1351
Merged
matlabbe merged 1 commit intointrolab:masterfrom Oct 6, 2024
Merged
Update iOS app's install_deps.sh to remove PCL's SSE dependency#1351matlabbe merged 1 commit intointrolab:masterfrom
matlabbe merged 1 commit intointrolab:masterfrom
Conversation
…e the script complete.
Member
|
That solution is better than my workaround in my other PR (#1340, calling a second time cmake), I'll merge to use your approach. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, I tried building the ios demo application and install_deps.sh was failing while trying to build PCL.
CMake was failing to produce XCode project because the check for SSE support was failing. I removed it, since as far as I know, it's not required for aarch64 builds.
Project builds nicely after updating the script.