Clicking Nodes\Links brings them up in viewer#1344
Merged
matlabbe merged 3 commits intointrolab:masterfrom Sep 22, 2024
Merged
Conversation
…. Removed unrelated border option crashing.
Member
|
That feature already existed here: rtabmap/guilib/src/GraphViewer.cpp Lines 1915 to 1939 in ddb9b54 but it was on double-click. I tried your PR and it feels better with single-click. I modified the PR to use single-click now. I also kept your spin boxes next to the main slider bars, which are indeed useful. I merged the spin box with the index label, as they represented the same function:
I removed the code about "highlighting" option, which seemed not used anywhere. The border context menu option also crashed when clicking on it, so I removed it. I suggest to open another MR if there was a new feature there that could be useful to keep. I'll merge now with those changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I added the ability to mouse click on nodes and links in the graph view and have them populate slider_A and slider_B in the main view window.